This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-838: Add user time format preference #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 4 flaky tests on run #15971 ↗︎
Details:
Review all test suite changes for PR #2280 ↗︎ |
||||||||||||||||||||
khelif96
approved these changes
Feb 28, 2024
Comment on lines
+228
to
+231
| {label && ( | ||
| <LabelContainer> | ||
| <Label htmlFor={id}>{label}</Label> | ||
| </LabelContainer> |
src/utils/string/index.ts
Outdated
| if (!dateFormat) { | ||
| dateFormat = "MMM d, yyyy"; | ||
| } | ||
| if (!timeFormat) { | ||
| timeFormat = "h:mm:ss aa"; |
There was a problem hiding this comment.
nit. could we reuse the TimeFormat enum declared above instead of duplicating here?
sophstad
force-pushed
the
DEVPROD-838
branch
from
4a10ee6 to
4ff87cf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-838
Description
Screenshots
Testing
Evergreen PR
evergreen-ci/evergreen#7569